[tor-bugs] #28897 [Core Tor/sbws]: Stop running twice destination usability tests

[Tor Bug Tracker & Wiki]

#28897: Stop running twice destination usability tests
---------------------------+-----------------------------------
 Reporter:  juga           |          Owner:  juga
     Type:  defect         |         Status:  needs_review
 Priority:  Medium         |      Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |        Version:  sbws: 1.0.2
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:  #28663         |         Points:
 Reviewer:  teor           |        Sponsor:
---------------------------+-----------------------------------

Comment (by teor):

 Replying to [comment:5 juga]:
 > '''Reminder''': when merging into master, add additional commit or fixup
 to change `circuit_id = cb.build_circuit(circuit_path)` into `circuit_id,
 _ = cb.build_circuit(circuit_path)` [0], as #28736 changed `build_circuit`
 to return a tuple.
 >
 > [0]
 https://github.com/torproject/sbws/pull/320/commits/b0aaf5d806276bfa946422d016da8506cc48a209
 #diff-9714c4c15b47a818a1e2537f9e1cd6f2R36 and
 https://github.com/torproject/sbws/pull/320/commits/b0aaf5d806276bfa946422d016da8506cc48a209
 #diff-9714c4c15b47a818a1e2537f9e1cd6f2R57

 I reviewed the pull request. I suggested some design changes to help sbws
 recover better from temporary failures.

 Can you please do a rebase or merge before the next review, so I can
 review the code that will be merged to master?

 Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28897#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online