[tor-bugs] #29559 [Obfuscation/meek]: meek-client-torbrowser should exit on stdin close, even while waiting on browser output

Tor Bug Tracker & Wiki blackhole at torproject.org
Sat Feb 23 07:48:15 UTC 2019


#29559: meek-client-torbrowser should exit on stdin close, even while waiting on
browser output
------------------------------+------------------------------
 Reporter:  dcf               |          Owner:  dcf
     Type:  defect            |         Status:  needs_review
 Priority:  Medium            |      Milestone:
Component:  Obfuscation/meek  |        Version:
 Severity:  Minor             |     Resolution:
 Keywords:                    |  Actual Points:
Parent ID:                    |         Points:
 Reviewer:                    |        Sponsor:
------------------------------+------------------------------
Changes (by dcf):

 * status:  new => needs_review


Comment:

 Here is a patch. It looks for the helper address in a background goroutine
 in order to simultaneously wait on `sigChan`.

 This is the patch I used to test, breaking the grep pattern so that
 `grepHelperAddress` would not return.
 {{{#!diff
 diff --git a/meek-client-torbrowser/meek-client-torbrowser.go b/meek-
 client-torbrowser/meek-client-torbrowser.go
 index 16f0ebc..2341cbc 100644
 --- a/meek-client-torbrowser/meek-client-torbrowser.go
 +++ b/meek-client-torbrowser/meek-client-torbrowser.go
 @@ -38,7 +38,7 @@ import (
  )

  // This magic string is emitted by meek-http-helper.
 -var helperAddrPattern = regexp.MustCompile(`^meek-http-helper: listen
 (127\.0\.0\.1:\d+)$`)
 +var helperAddrPattern = regexp.MustCompile(`^meek-http-helper: listenXXX
 (127\.0\.0\.1:\d+)$`)

  func usage() {
         fmt.Fprintf(os.Stderr, "Usage: %s [meek-client-torbrowser args] --
 meek-client [meek-client args]\n", os.Args[0])
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29559#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list