[tor-bugs] #29204 [Core Tor/Tor]: Inspect circuit queue during padidng decisions

[Tor Bug Tracker & Wiki]

#29204: Inspect circuit queue during padidng decisions
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad, 041-proposed, network-      |  Actual Points:
  team-roadmap-2019-Q1Q2                         |
Parent ID:  #28634                               |         Points:  5
 Reviewer:  dgoulet                              |        Sponsor:
                                                 |  Sponsor2
-------------------------------------------------+-------------------------

Comment (by dgoulet):

 So after discussion with Mike on IRC, the approach in the patch is good.
 It is correct to only look at the circuit queue since circuit padding
 needs to pad on a per-circuit level.

 Two things. First, I think this is an artifact that shouldn't be in the
 patch:

 {{{
   mi->is_padding_timer_scheduled = 0;
 }}}

 Second, because this adds a new consensus param so we'll need a
 torspec.git patch before we release stable.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29204#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online