[tor-bugs] #29060 [Core Tor/Tor]: shellcheck: test-network.sh issues

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Feb 21 19:16:16 UTC 2019


#29060: shellcheck: test-network.sh issues
----------------------------+------------------------------------
 Reporter:  rl1987          |          Owner:  rl1987
     Type:  defect          |         Status:  needs_review
 Priority:  Medium          |      Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:                  |         Points:
 Reviewer:  ahf             |        Sponsor:
----------------------------+------------------------------------
Changes (by rl1987):

 * status:  needs_revision => needs_review


Comment:

 In c346eff223e94b5fbeb6e751a99393fc5f7dd4b0 I'm trying to walk away from
 requiring bash by removing the `ORIGINAL_ARGS` array/variable.

 Not sure I'm not breaking something here. Why did we save `$@` into a
 variable in the first place?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29060#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list