[tor-bugs] #29553 [Core Tor/Tor]: pre-commit hook gives a warning when there are no changes files, when source files aren't where expected, and doesn't exit. (was: pre-commit hook gives a warning when there are no changes files, )

[Tor Bug Tracker & Wiki]

#29553: pre-commit hook gives a warning when there are no changes files, when
source files aren't where expected, and doesn't exit.
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  assigned
 Priority:  Medium        |      Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:  .1
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Description changed by nickm:

Old description:

> Problem 1:
>
> {{{
> Traceback (most recent call last):
>   File "scripts/maint/lintChanges.py", line 111, in <module>
>     if lintfile(fname):
>   File "scripts/maint/lintChanges.py", line 53, in lintfile
>     with open(fname) as f:
> IOError: [Errno 2] No such file or directory: './changes/*'
> On branch release-0.3.5
> Your branch is up to date with 'origin/release-0.3.5'.
> }}}
>
> Problem 2:  The script lets me commit anyway.

New description:

 Problem 1:

 {{{
 Traceback (most recent call last):
   File "scripts/maint/lintChanges.py", line 111, in <module>
     if lintfile(fname):
   File "scripts/maint/lintChanges.py", line 53, in lintfile
     with open(fname) as f:
 IOError: [Errno 2] No such file or directory: './changes/*'
 On branch release-0.3.5
 Your branch is up to date with 'origin/release-0.3.5'.
 }}}

 Problem 2:  The script lets me commit anyway.

 Problem 3:  It doesn't run checkSpace.pl on the right locations for our
 pre-0.3.5 source layout.

--

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29553#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online