[tor-bugs] #29552 [Core Tor/Tor]: memory leak: protover_contains_long_protocol_names in protover.c calls parse_protocol_list, but doesn't free smartlist returned (treats it as a boolean)

[Tor Bug Tracker & Wiki]

#29552: memory leak: protover_contains_long_protocol_names in protover.c calls
parse_protocol_list, but doesn't free smartlist returned (treats it as a
boolean)
---------------------------+------------------------------
 Reporter:  drjohnson1984  |          Owner:  (none)
     Type:  defect         |         Status:  closed
 Priority:  High           |      Milestone:
Component:  Core Tor/Tor   |        Version:  Tor: 0.3.3.7
 Severity:  Normal         |     Resolution:  invalid
 Keywords:  memory-leak    |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+------------------------------

Comment (by dgoulet):

 Replying to [comment:2 drjohnson1984]:
 > The code looked like this in 0.3.3.7:

 Ah! So 0.3.3.x is end of life in 7 days. I would strongly suggest to use
 at least 0.3.4 :).

 It was backported in 0.3.3.8:

 {{{
   o Major bugfixes (directory authority, backport from 0.3.4.3-alpha):
     - Stop leaking memory on directory authorities when planning to
       vote. This bug was crashing authorities by exhausting their
       memory. Fixes bug 26435; bugfix on 0.3.3.6.
 }}}

 See #26435.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29552#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online