[tor-bugs] #29552 [Core Tor]: memory leak: protover_contains_long_protocol_names in protover.c calls parse_protocol_list, but doesn't free smartlist returned (treats it as a boolean)

[Tor Bug Tracker & Wiki]

#29552: memory leak: protover_contains_long_protocol_names in protover.c calls
parse_protocol_list, but doesn't free smartlist returned (treats it as a
boolean)
---------------------------+--------------------------
 Reporter:  drjohnson1984  |          Owner:  (none)
     Type:  defect         |         Status:  new
 Priority:  Medium         |      Component:  Core Tor
  Version:  Tor: 0.3.3.7   |       Severity:  Normal
 Keywords:  memory-leak    |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+--------------------------
 The function parse_protocol_list in protover.c allocates a smartlist, and
 returns a pointer to the smartlist as long as there are no parse errors.
 The funcction protover_contains_long_protocol_names calls the former, but
 should capture and delete the returned smartlist if it is not null.

 I searched the database for these function names and they didn't show up,
 so I assume this is unreported and still a problem.  I apologize if I
 missed it somehow.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29552>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online