[tor-bugs] #29527 [Core Tor/Tor]: Division by zero: undefined behaviour in circuitpadding/circuitpadding_sample_distribution test

[Tor Bug Tracker & Wiki]

#29527: Division by zero: undefined behaviour in
circuitpadding/circuitpadding_sample_distribution test
------------------------------------------+--------------------------------
 Reporter:  teor                          |          Owner:  (none)
     Type:  defect                        |         Status:  new
 Priority:  Medium                        |      Milestone:  Tor:
                                          |  0.4.0.x-final
Component:  Core Tor/Tor                  |        Version:
 Severity:  Normal                        |     Resolution:
 Keywords:  regression, tor-ci, tor-test  |  Actual Points:
Parent ID:                                |         Points:
 Reviewer:                                |        Sponsor:
------------------------------------------+--------------------------------

Comment (by teor):

 There are actually more of these than I thought:
 {{{
 prob_distr/logit_logistics: [forking] ../src/lib/math/prob_distr.c:427:26:
 runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/lib/math/prob_distr.c:427:26 in
 ../src/lib/math/prob_distr.c:344:17: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/lib/math/prob_distr.c:344:17 in
 OK
 prob_distr/log_logistic: [forking] ../src/test/test_prob_distr.c:496:5:
 runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:496:5 in
 ../src/test/test_prob_distr.c:496:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:496:5 in
 ../src/test/test_prob_distr.c:497:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:497:5 in
 ../src/test/test_prob_distr.c:497:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:497:5 in
 ../src/test/test_prob_distr.c:498:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:498:5 in
 ../src/test/test_prob_distr.c:498:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:498:5 in
 ../src/test/test_prob_distr.c:499:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:499:5 in
 ../src/test/test_prob_distr.c:499:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:499:5 in
 ../src/test/test_prob_distr.c:500:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:500:5 in
 ../src/test/test_prob_distr.c:500:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:500:5 in
 ../src/test/test_prob_distr.c:501:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:501:5 in
 ../src/test/test_prob_distr.c:501:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:501:5 in
 ../src/test/test_prob_distr.c:508:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:508:5 in
 ../src/test/test_prob_distr.c:508:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:508:5 in
 ../src/test/test_prob_distr.c:509:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:509:5 in
 ../src/test/test_prob_distr.c:509:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:509:5 in
 ../src/test/test_prob_distr.c:510:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:510:5 in
 ../src/test/test_prob_distr.c:510:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:510:5 in
 ../src/test/test_prob_distr.c:511:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:511:5 in
 ../src/test/test_prob_distr.c:511:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:511:5 in
 ../src/test/test_prob_distr.c:512:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:512:5 in
 ../src/test/test_prob_distr.c:512:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:512:5 in
 ../src/test/test_prob_distr.c:513:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:513:5 in
 ../src/test/test_prob_distr.c:513:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:513:5 in
 ../src/test/test_prob_distr.c:553:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:553:5 in
 ../src/lib/math/prob_distr.c:685:27: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/lib/math/prob_distr.c:685:27 in
 ../src/test/test_prob_distr.c:553:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:553:5 in
 ../src/test/test_prob_distr.c:554:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:554:5 in
 ../src/test/test_prob_distr.c:554:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:554:5 in
 ../src/test/test_prob_distr.c:555:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:555:5 in
 ../src/test/test_prob_distr.c:555:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:555:5 in
 ../src/test/test_prob_distr.c:556:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:556:5 in
 ../src/test/test_prob_distr.c:556:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:556:5 in
 ../src/test/test_prob_distr.c:557:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:557:5 in
 ../src/test/test_prob_distr.c:557:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:557:5 in
 ../src/test/test_prob_distr.c:558:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:558:5 in
 ../src/test/test_prob_distr.c:558:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:558:5 in
 ../src/test/test_prob_distr.c:559:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:559:5 in
 ../src/test/test_prob_distr.c:559:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:559:5 in
 ../src/test/test_prob_distr.c:560:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:560:5 in
 ../src/test/test_prob_distr.c:560:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:560:5 in
 ../src/test/test_prob_distr.c:561:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:561:5 in
 ../src/test/test_prob_distr.c:561:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:561:5 in
 ../src/test/test_prob_distr.c:568:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:568:5 in
 ../src/lib/math/prob_distr.c:1170:20: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/lib/math/prob_distr.c:1170:20 in
 ../src/test/test_prob_distr.c:568:5: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/test/test_prob_distr.c:568:5 in
 OK
 prob_distr/weibull: [forking] OK
 prob_distr/genpareto: [forking] ../src/lib/math/prob_distr.c:814:23:
 runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/lib/math/prob_distr.c:814:23 in
 ../src/lib/math/prob_distr.c:837:23: runtime error: division by zero
 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
 ../src/lib/math/prob_distr.c:837:23 in
 OK
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29527#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online