#29018: Make all statistics depend on ExtraInfoStatistics
------------------------------------+------------------------------------
Reporter: teor | Owner: teor
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: fast-fix, security-low | Actual Points: 0.1
Parent ID: | Points: 0.1
Reviewer: nickm | Sponsor: SponsorV-can
------------------------------------+------------------------------------
Comment (by teor):
Replying to [comment:5 teor]:
> Replying to [comment:4 nickm]:
> > This looks fine to me. A quick question before I merge: I see that
coverage has fallen here. Do you think you would time to add a test for
this stuff?
>
> I could tweak the existing tests to run with ExtraInfoStatistics 0 and
1. That should improve coverage compared to master.
Actually, there are no existing tests that build an extrainfo document.
Instead, the existing tests mock the relevant functions, replacing them
with static descriptor strings.
These static descriptor strings are also out of date. I opened #29521 to
address this technical debt, because I don't have time to do it in Sponsor
V.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29018#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online