[tor-bugs] #28868 [Core Tor/sbws]: best_priority() can starve the worker threads of good relays

[Tor Bug Tracker & Wiki]

#28868: best_priority() can starve the worker threads of good relays
---------------------------+-----------------------------------
 Reporter:  teor           |          Owner:  juga
     Type:  defect         |         Status:  merge_ready
 Priority:  Medium         |      Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |        Version:  sbws: 1.0.2
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:  #28663         |         Points:
 Reviewer:  ahf            |        Sponsor:
---------------------------+-----------------------------------
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 The code in PR328 looks reasonable to me. I added a minor comment to a
 boolean expression, but nothing blocking.

 I still feel that I don't know the codebase well enough to say if changes
 are net positive/negative for the overall codebase, but I trust juga to
 get those details right.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28868#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online