[tor-bugs] #29060 [Core Tor/Tor]: shellcheck: test-network.sh issues

[Tor Bug Tracker & Wiki]

#29060: shellcheck: test-network.sh issues
----------------------------+------------------------------------
 Reporter:  rl1987          |          Owner:  rl1987
     Type:  defect          |         Status:  needs_revision
 Priority:  Medium          |      Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:                  |         Points:
 Reviewer:  ahf             |        Sponsor:
----------------------------+------------------------------------

Comment (by rl1987):

 Replying to [comment:6 ahf]:
 > I think these patches looks good with 2 things that we need to figure
 out. I just asked these questions on IRC as well.
 >
 > 1. bash isn't always located in `/bin/bash` so it might be smarter if we
 use `/usr/bin/env bash` for the shebang line. On FreeBSD things installed
 from ports go to `/usr/local/` as prefix.

 Did so in 4f9061868b04724bf3eaecddf9b536c189bd34da.

 > 2. Should we use `.bash` instead of `.sh` for bash scripts? I think yes,
 but I'm not sure what everyone else thinks here.
 >
 > The second question is a bit more open. Let's fix the first one now and
 then we can figure out if we should do question 2 as well later :-)

 Opened #29488 for this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29060#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online