[tor-bugs] #32818 [Core Tor/Tor]: Standardise EXPOSE and INTERNAL macros to PRIVATE

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Dec 20 03:32:27 UTC 2019


#32818: Standardise EXPOSE and INTERNAL macros to PRIVATE
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  teor
     Type:  task          |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  0.2
Parent ID:  #32798        |         Points:  0.5
 Reviewer:  nickm         |        Sponsor:
--------------------------+------------------------------------

Comment (by teor):

 Here's how I searched for replacements:
 {{{
 $ grep -r '#.*if.*def.*[A-Z_]*\(INTERNAL\|EXPOSE\)[A-Z_]*' src | grep -v
 -e 'src/ext' -e 'include.am'
 src/lib/err/backtrace.h:#ifdef EXPOSE_CLEAN_BACKTRACE
 src/lib/err/backtrace.h:#endif /* defined(EXPOSE_CLEAN_BACKTRACE) */
 ...
 src/core/or/channeltls.h:#ifdef TOR_CHANNEL_INTERNAL_
 src/core/or/channeltls.h:#endif /* defined(TOR_CHANNEL_INTERNAL_) */
 src/core/or/channel.h:#ifdef TOR_CHANNEL_INTERNAL_
 src/core/or/channel.h:#endif /* defined(TOR_CHANNEL_INTERNAL_) */
 ...
 src/feature/dirparse/routerparse.h:#ifdef EXPOSE_ROUTERDESC_TOKEN_TABLE
 $ grep -r '#.*if.*def.*PRIVATE_' src | grep -v -e 'src/ext' -e
 'include.am'
 src/core/or/scheduler.h:#ifdef SCHEDULER_PRIVATE_
 src/core/or/scheduler.h:#endif /* defined(SCHEDULER_PRIVATE_) */
 src/core/or/channel.h:#ifdef CHANNEL_PRIVATE_
 src/core/or/channel.h:#endif /* defined(CHANNEL_PRIVATE_) */
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32818#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list