[tor-bugs] #32798 [Core Tor/Tor]: Compile every header by itself as part of "make check"

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Dec 18 14:21:26 UTC 2019

#32798: Compile every header by itself as part of "make check"
     Reporter:  teor          |      Owner:  (none)
         Type:  task          |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.4.3.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:  #32764
       Points:  2             |   Reviewer:
      Sponsor:                |
 In #32764, we need to make sure that some headers include their
 dependencies (or remove those dependencies), so that clang-format can re-
 order headers.

 We should compile every header by itself, to check that it lists all its
 dependencies. Some headers contain conditional code, so we also need to
 compile with and without:
 * HAVE_MODULE_* (already in CI, as long as we use the defined from
 * *{INTERNAL,PRIVATE,EXPOSE}* (not sure how to do this in CI, I guess we
 could script it using grep)

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32798>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tor-bugs mailing list