[tor-bugs] #32764 [Core Tor/Tor]: Solve code issues that block running clang-format on our code.

[Tor Bug Tracker & Wiki]

#32764: Solve code issues that block running clang-format on our code.
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  1
Parent ID:  #29226        |         Points:  1
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 I think options_validate_dirauth_mode(), set_server_advertised(),
 options_validate_server_transport() and options_validate_relay_mode() all
 introduce similar dependencies to authdir_mode_v3(). (Mostly on
 or_options_t.)

 But they only add those dependencies in disable relay/dirauth mode, so you
 might not have seen any compilation issues after header re-ordering?

 I'd like to see a test branch with these changes, and the header re-
 ordering, so that we can check all our standard builds in CI.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32764#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online