[tor-bugs] #32750 [Applications/Tor Browser]: Sign nightly sha256sums files with gpg

[Tor Bug Tracker & Wiki]

#32750: Sign nightly sha256sums files with gpg
-------------------------------------------------+-------------------------
 Reporter:  boklm                                |          Owner:  boklm
     Type:  task                                 |         Status:  closed
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  tbb-rbm, tbb-update,                 |  Actual Points:  .1
  TorBrowserTeam201912R                          |
Parent ID:  #18867                               |         Points:  .1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:5 boklm]:
 > Replying to [comment:4 gk]:
 > > Replying to [comment:3 boklm]:
 > > > I fixed that in `bug_32750_v4`:
 > > > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_32750_v4&id=32ce9d2bf8bbd09017533175ffebf0b3599eb617
 > >
 > > Thanks. While looking at the commit again: can't we just set
 `sign_build` to `1` in case `nightly_build_sign_build` is defined?
 >
 > If we do that then if we set `nightly_build_sign_build` to `0`, then
 `sign_build` will still be enabled, which can be confusing.

 Yeah, I was more thinking about not setting `nightly_build_sign_build` at
 all in that case (that is instead setting it to `0`). But I guess this
 might be confusing in its own way. So, works for me.

 Merged to `master` (commit b61a0497f0258ffebb2586c41267462e16a69cf0).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32750#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online