[tor-bugs] #23744 [Core Tor/Tor]: sched: Notification events have different meaning for each scheduler

[Tor Bug Tracker & Wiki]

#23744: sched: Notification events have different meaning for each scheduler
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-sched, 034-triage-20180328,      |  Actual Points:
  034-removed-20180328                           |
Parent ID:  #23993                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by dgoulet):

 So (1) is really about making these:

 {{{
 void scheduler_channel_wants_writes(channel_t *chan);
 MOCK_DECL(void, scheduler_channel_doesnt_want_writes, (channel_t *chan));
 MOCK_DECL(void, scheduler_channel_has_waiting_cells, (channel_t *chan));
 }}}

 ... function calls in `scheduler_t` which becomes specific per-scheduler
 type.

 (2) would resolve #32388 that is scheduler could initialize properly a
 channel when it opens instead of living the bug.

 (3) will come with (1).

 Bottom line, (1) is what needs to be fixed with this ticket. It is pretty
 much simple. Code duplication is at risk but we can always have common
 code shared with something like `scheduler_common.c`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23744#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online