[tor-bugs] #27045 [Applications/Tor Browser]: Add option for firefox incremental builds

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Dec 16 10:22:49 UTC 2019


#27045: Add option for firefox incremental builds
-------------------------------------------+-------------------------------
 Reporter:  boklm                          |          Owner:  tbb-team
     Type:  task                           |         Status:
                                           |  needs_revision
 Priority:  Medium                         |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201912  |  Actual Points:
Parent ID:                                 |         Points:
 Reviewer:  gk                             |        Sponsor:
-------------------------------------------+-------------------------------
Changes (by gk):

 * keywords:  tbb-rbm, TorBrowserTeam201912R => tbb-rbm,
               TorBrowserTeam201912
 * status:  needs_review => needs_revision


Comment:

 Okay, I am finally getting to review this. Sorry for the long delay. I
 think it's a nice feature to have.

 I used my `bug_27045_rebase2` branch for testing. Apart from failing to
 build
 {{{
 Starting build: Mon Dec 16 10:07:49 2019
 /var/tmp/dist/gcc/bin ~
 ~
 mv: cannot create regular file `.mozconfig': Permission denied
 }}}
 here a couple of issues we might want to address:

 a) the `ffdev` version should be available for mobile targets, too, now
 b) "The patch that may be applied in projects/firefox/build are not
 applied" s/patch/patches
 c) we should not hardcode `copyright_year`
 d)
 {{{
 +            "options": [
 +              "rbind"
 +              ]
 }}}
 it seems `]` is wrongly indented.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27045#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list