[tor-bugs] #32139 [Core Tor/Tor]: Disable all dirauth options when those modules are disabled

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Dec 16 02:41:04 UTC 2019


#32139: Disable all dirauth options when those modules are disabled
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-design, network-team-roadmap-    |  Actual Points:
  november                                       |
Parent ID:  #31851                               |         Points:  2
 Reviewer:  teor                                 |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  assigned => needs_review
 * reviewer:   => teor


Comment:

 I have some initial work here in a branch called `dirauth_config`.  It
 isn't ready for merge, but I've made a PR at
 https://github.com/torproject/tor/pull/1607 to see what CI thinks.

 So far, it moves only a single option into a separate dirauth
 configuration object.  Additionally, it makes some changes needed so that
 disableable modules can "own" their own options:
    1. Subsystems associated with disabled modules are no longer "missing".
 Instead, they are "stub" subsystems that do nothing, but which still
 declare disabled options.
    2. There is support for a flag that marks options as "disabled".

 I'd like some preliminary feedback here if you have time.  What do you
 think of this approach?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32139#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list