[tor-bugs] #32753 [Core Tor/Tor]: Tor should lower-case its BridgeDistribution string

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Dec 13 19:24:39 UTC 2019

#32753: Tor should lower-case its BridgeDistribution string
     Reporter:  arma          |      Owner:  (none)
         Type:  enhancement   |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
 See comment:8 in #32547, where phw tells a bridge operator that they need
 to set BridgeDistribution to "none", because using "None" is not right.

 That isn't a good user experience, and it's easy to fix.

 One option is that inside check_bridge_distribution_setting() when we do
 {{{if (!strcmp(bd, RECOGNIZED[i]))}}} we should do strcasecmp instead.
 That is, don't complain if it's a recognized value and the only issue is
 that it's not all lowercase.

 But a better option imo is that we lowercase it in place first, so that if
 the user types None, bridgedb still sees none.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32753>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tor-bugs mailing list