[tor-bugs] #30558 [Applications/Tor Browser]: Namecoin support for onion sites in Tor Browser

[Tor Bug Tracker & Wiki]

#30558: Namecoin support for onion sites in Tor Browser
--------------------------------------+--------------------------------
 Reporter:  arthuredelstein           |          Owner:  JeremyRand
     Type:  defect                    |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201912      |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:  gk                        |        Sponsor:
--------------------------------------+--------------------------------

Comment (by gk):

 Replying to [comment:43 JeremyRand]:
 > > g) ncdns: the goxlog dependency does not seem to be needed, please
 remove it.
 >
 > `ncprop279` imports `github.com/namecoin/ncdns/backend`, which imports
 `github.com/hlandau/xlog`.  So I think it's appropriate to have `goxlog`
 as a dependency of `ncdns`.  I suspect that `goxlog` is getting pulled in
 via another dependency (probably `godexlogconfig`) as well, which I
 suppose means that it will build without errors if `goxlog` is omitted
 from `ncdns`, but I don't think it's a good idea to omit it from `ncdns`'s
 dependencies, since it's directly imported from an `ncdns` package.  But,
 if you really want me to omit `goxlog` from `ncdns`'s dependencies, let me
 know and I'll do it.

 The dependencies in the config file (more exactly, those mentioned in
 `input_files`) specify the *build* dependencies which means projects in
 tor-browser-build that are needed to get built before the project in
 question can get compiled. For `goxlog` you don't specify it in
 `go_lib_deps` but in `input_files`, yet the compilation succeeds. That is
 an indication that `goxlog` is not directly needed for building `ncdns`.
 Thus, please remove it from `input_files`, too.

 The config file is not meant to be an universal dependency tracker in the
 sense that one can see any dependency, recursively down to the last one,
 just by looking at that file.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30558#comment:44>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online