[tor-bugs] #31882 [Core Tor/Tor]: move Android build config into core tor

[Tor Bug Tracker & Wiki]

#31882: move Android build config into core tor
---------------------------------+------------------------------------
 Reporter:  eighthave            |          Owner:  nickm
     Type:  defect               |         Status:  accepted
 Priority:  Medium               |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor         |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:  Android, tbb-mobile  |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:  nickm                |        Sponsor:
---------------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => accepted
 * owner:  (none) => nickm


Comment:

 The PR can't be merged as-is.  The android log parts are now #32181, where
 we're taking a simpler approach and just removing them.  That leaves these
 parts:
   * Changing `--enable-android` to imply a suite of other options
   * Removing USE_ANDROID.

 I think removing USE_ANDROID is fine to do after #32181 is merged, since
 we'll have a conflict there.

 This leaves changing `--enable-android` to imply `--disable-asciidoc
 --disable-html-manual --disable-manpage --enable-pic --disable-system-
 torrc --disable-tool-name-check --disable-systemd`.  For that, I'd like to
 survey a couple of other android integrators to see if they'd also want
 those defaults, and whether they'd think that a
 "contrib/configure_android.sh" script was adequate.  If they _do_ want
 something like this:

    1. Then the configure option should change the defaults, not override
 other settings.
    2. Probably it should get a new name other than --enable-android, since
 most of the changes have nothing to do with being android-specific, and
 since --enable-android used to mean something else.

 I'll take that on.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31882#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online