[tor-bugs] #31518 [Core Tor/Tor]: HAProxy implementation in TCPProxy option.

[Tor Bug Tracker & Wiki]

#31518: HAProxy implementation in TCPProxy option.
--------------------------+------------------------------------
 Reporter:  haxxpop       |          Owner:  haxxpop
     Type:  enhancement   |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  proxy tcp     |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  nickm         |        Sponsor:
--------------------------+------------------------------------

Comment (by nickm):

 I'm still almost okay to merge this.  Just two issues:

 1) "maek check" doesn't pass, because of a lintChanges issue.

 2.  I'm still wondering if it's okay to do  connection_start_reading()
 unconditionally in  connection_or_finished_connecting().  I left a
 response to your response on the PR there back in Oct 25:
 https://github.com/torproject/tor/pull/1248#discussion_r339032153

 If I get your go-ahead to fix the lintChanges issue and make the
 connection_start_reading() call unconditional, I will fix those, make sure
 CI still passes, and merge.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31518#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online