[tor-bugs] #30558 [Applications/Tor Browser]: Namecoin support for onion sites in Tor Browser

[Tor Bug Tracker & Wiki]

#30558: Namecoin support for onion sites in Tor Browser
--------------------------------------+--------------------------------
 Reporter:  arthuredelstein           |          Owner:  JeremyRand
     Type:  defect                    |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201912      |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:  gk                        |        Sponsor:
--------------------------------------+--------------------------------
Changes (by gk):

 * keywords:  TorBrowserTeam201912R => TorBrowserTeam201912
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:32 JeremyRand]:
 > Sorry this revision took so long; there was quite a bit of tinkering
 required, given various quirks in how the Python libs are built.  But, the
 good news is that yes, building without `sdist` works fine AFAICT.  I've
 removed the conditional variables from electrum-nmc and certifi.  There
 were also 2 conditional variables in the ncdns and ncprop279 projects,
 which I've removed as well.
 >
 > Updated branch at https://notabug.org/JeremyRand/tor-browser-
 build/src/namecoin-v2 (Git commit hash
 `111d7d1447b47e5290fd0234174a7c29c1351a7b`).

 Thanks looks better now. commit 84888715acfda26e2735805e970ec77dd2d1f56e:

 a)

 You create the project dir with
 {{{
 +mkdir -p /var/tmp/dist/[% project %]
 }}}
 but then often create another project dir you then you like so
 {{{
 +mkdir ./[% project %]
 +cp -a $rootdir/[% project %]*/[% project %]/*.py ./[% project %]/
 }}}
 This `[% project %]/[% project %]/` setup is essentially happening in
 every project. Could you avoid that and just do a
 {{{
 +mkdir -p /var/tmp/dist/[% project %]
 +cd /var/tmp/dist/
 }}}
 (note: you are no changing into the project dir here)
 Then there is no need to create yet another project dir but you can just
 use that one you already created with `mkdir -p`.

 b)

 {{{
 +cd /var/tmp/dist/[% project %]
 +
 +mkdir ./[% project %]
 +cd $rootdir/dnspython*/[% project %]
 +cp --parents **/*.py /var/tmp/dist/[% project %]/[% project %]/
 +
 +cd /var/tmp/dist/[% project %]
 }}}
 Do we really need to change the dir back and forth here?

 c)
 {{{
 +tar xvf [% project %]-[% c('version') %].tar.gz
 +
 +mkdir -p /var/tmp/dist/[% project %]
 +cd /var/tmp/dist/[% project %]
 +
 +cp -a $rootdir/[% project %]*/[% project %].py ./[% project %].py
 }}}
 For the projects that use snippets like the above it's not clear to me why
 you create the `[% project %]` dir at all if you are just using that
 single file directly. So, just `mkdir -p /var/tmp/dist` etc. should be
 enough.

 (Again, when you make those changes, please adjust subsequent commits,
 too, in case they are affected)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30558#comment:34>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online