[tor-bugs] #30558 [Applications/Tor Browser]: Namecoin support for onion sites in Tor Browser

[Tor Bug Tracker & Wiki]

#30558: Namecoin support for onion sites in Tor Browser
--------------------------------------+--------------------------------
 Reporter:  arthuredelstein           |          Owner:  JeremyRand
     Type:  defect                    |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201912      |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:  gk                        |        Sponsor:
--------------------------------------+--------------------------------
Changes (by gk):

 * keywords:  TorBrowserTeam201912R => TorBrowserTeam201912


Comment:

 Thanks for addressing my previous points. Now let's look at commit
 3fb39eeac9cb898245bc38f1444f48984a09a1a8:

 1) Looking at the `electrum-nmc` project there are a bunch of features
 that are conditional. However, there are no plans right now to offer
 conditional Namecoin features in Tor Browser nightly builds. Please remove
 all the complexity here and just take what we want to ship initially.

 2) For the `certifi` config, see 1) above. There is no need to include the
 root certs conditionally.

 3) The build scripts for the dependencies seem to be quite complex given
 that they should just create a tarball of .py at the end if I see that
 right: you invoke first `sdist` to create what essentially is already a
 source tarball just to shuffle things around later on to create the source
 tarball in rbm-style which you actually use later on. Could we avoid one
 of those two steps here? Like, could we just do the Python source tarball
 creation here and use that one (maybe with some general, not per-project,
 post-processing later on when those sources are getting used)? If not,
 could we just zip up the necessary .py files ourselves avoiding the Python
 steps?

 4) If we stick to the Python `sdist` process I think it is not necessary
 to specify `--format=gztar` as this should be the default on Unix-like
 systems (which are the only systems we use for building).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30558#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online