[tor-bugs] #32500 [Core Tor/Tor]: consider clang -std=gnu99 in Travis for better C99 portability

[Tor Bug Tracker & Wiki]

#32500: consider clang -std=gnu99 in Travis for better C99 portability
-------------------------------------------------+-------------------------
 Reporter:  catalyst                             |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  portability, tor-ci, 029-backport,   |  Actual Points:  0.5
  035-backport, 040-backport, 041-backport,      |
  042-backport                                   |
Parent ID:                                       |         Points:  0.1
 Reviewer:  catalyst                             |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by catalyst):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:14 teor]:
 > We were using the trusty gcc for all our builds until about a month ago
 :-)
 >
 > I'm going to experiment with using the NSS gcc in later Tor versions.
 There are two advantages:
 > * we'll test the NSS-specific code with `-std=gnu99`
 > * we'll get a later gcc version
 >
 > Same PRs and tests as before, but it only affects 0.3.5 and later.
 >
 > (Thanks for your patience with this ticket!)
 Thanks! Looks good now.

 I do think we want to make a comment explaining that
 `SKIP_MAKE_CHECK="yes"` is required on Trusty at the moment because its
 coccinelle is too old to parse our C files. Would you rather to it as part
 of this ticket, or as a new ticket?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32500#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online