[tor-bugs] #32516 [Applications/Tor Browser]: Make Write Methods Clearer in TorConfigBuilder

[Tor Bug Tracker & Wiki]

#32516: Make Write Methods Clearer in TorConfigBuilder
-----------------------------------------------+---------------------------
 Reporter:  sisbell                            |          Owner:  tbb-team
     Type:  defect                             |         Status:
                                               |  needs_review
 Priority:  Medium                             |      Milestone:
Component:  Applications/Tor Browser           |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201911R  |  Actual Points:
Parent ID:                                     |         Points:  .25
 Reviewer:                                     |        Sponsor:
-----------------------------------------------+---------------------------
Changes (by sisbell):

 * keywords:  tbb-mobile, TorBrowserTeam201911 => tbb-mobile,
     TorBrowserTeam201911R
 * status:  needs_revision => needs_review


Comment:

 Changes:

 https://github.com/sisbell/Tor_Onion_Proxy_Library/commit/75491165af6339f28503eae09b1984632df78b0c

  1. Use writeAddress for orPort. SocksListenAddress doesn't take a port
 (as far as I can tell) so I can't use the writeAddress method for it as
 this would add ':auto' constant to the field.
  1. ClientTransportPlugin loads meek_lite, obf3 and obfs4 on same line.
 The implementation will write out all of the supported bridges from
 settings onto a single line. This assumes that all bridges can be handled
 by one clientTransportPlugin. This is suitable for the Android
 implementation but we should revisit this issue later.
  1. Use varargs for writeLine method so we can add as many values as we
 like
  1. Changed writeTrueProperty and writeFalseProperty to use writeLine
  1. The auto port issue was fixed in previous commit (and is also in this
 commit). Port will be "auto" if null or if port value is less than 0.

 Open Issues:

  1. SocksListenAddress is deprecated. So need to investigate
 removal/migration of the field. This needn't be addressed in this commit.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32516#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online