[tor-bugs] #32655 [Core Tor/Tor]: Try finding unused includes by compiling without each include

[Tor Bug Tracker & Wiki]

#32655: Try finding unused includes by compiling without each include
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:  teor
         Type:  task          |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.4.3.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  teor-backlog
Actual Points:                |  Parent ID:  #32522
       Points:  3             |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 In #32522, we deleted some includes and PRIVATE defines, because they were
 duplicate (or the defines were never actually checked in the headers).

 But we could go further, using this algorithm:
 1. Make sure all the files are sorted
 2. Find all the includes (and maybe PRIVATE defines)
 3. Delete the first include
 4. Try compiling
 5. If the include is required to compile, revert
 6. Try again from step 3, with the next include

 We'd need to skip conditional includes, and check the results in CI before
 merging.

 I'll wait until #32522 is reviewed, and also see if we want this task on
 our roadmap.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32655>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online