[tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

[Tor Bug Tracker & Wiki]

#31567: NS_tsnprintf() does not handle %s correctly on Windows
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  gk
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Critical                             |     Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,        |  Actual Points:
  TorBrowserTeam201908                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:18 gk]:
 > Replying to [comment:16 mcs]:
 > > Replying to [comment:14 pospeselr]:
 > > > ...
 > > > Patching the binary at runtime in windbg and letting it run results
 in these files:
 > > >
 > > > update.log:
 > > >
 > > > {{{
 > > > PATCH DIRECTORY
 C:\Users\user\Desktop\GKTest\Browser\TorBrowser\UpdateInfo\updates\0
 > > > INSTALLATION DIRECTORY C:\Users\user\Desktop\GKTest
 > > > WORKING DIRECTORY C:\Users\user\Desktop\GKTest
 > > > failed: 6
 > > > calling QuitProgressUI
 > > > }}}
 > > >
 > > > update.status:
 > > > {{{
 > > > failed: 6
 > > > }}}
 > > >
 > > > Not sure what the correct behaviour is here with regards to the
 updater but at least we get this far.
 > >
 > > I don't know why Mozilla doesn't add an errorToString() function for
 the updater error codes so they could log something more intelligible, but
 so far they have not done so. Anyway, you can find the updater error codes
 here:
 > > https://gitweb.torproject.org/tor-
 browser.git/tree/toolkit/mozapps/update/common/updatererrors.h?h=tor-
 browser-68.1.0esr-9.0-1
 > >
 > > Error 6 is `READ_ERROR` and that is probably happening because I
 forgot to tell you to copy Georg's test mar file to
 `...\updates\0\update.mar`. Sorry!
 >
 > Good point, let me test that.

 Yeah, that's been the problem. Now I get the error from `#define
 CERT_VERIFY_ERROR 19`. So, let me sign the .mar file next and try again.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31567#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online