[tor-bugs] #31010 [Applications/Tor Browser]: Rebase Tor Browser mobile/ patches for Firefox ESR 68

[Tor Bug Tracker & Wiki]

#31010: Rebase Tor Browser mobile/ patches for Firefox ESR 68
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-9.0-must-nightly,    |  Actual Points:
  TorBrowserTeam201908R                          |
Parent ID:  #30429                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 Okay, great! I rebased the commits (except the last one) on top of `tor-
 browser-68.1.0esr-9.0-1` (`adb1614b652a5be21e7f025d15a8ea48401eeb02`). You
 can reproduce this with: `git cherry-pick acat/30429+5..acat30429+5_tor-
 browser_android_68esr_54~` (where `acat/30429+5` is
 `677a3a505f714a9379735a189a43349c4097231a`).

 In any case, after cherry-picking all of the commits, I made a few
 modifications - including deleting the `Promise.resolve()`, as it was
 previously mentioned :)

 I have branch `bug31010_4`. There is an additional change needed in
 torbutton because `addTrustedTab` is not defined, so we need to revert the
 recent change that introduced this for mobile.

 {{{
 diff --git a/chrome/content/torbutton.js b/chrome/content/torbutton.js
 index 756c2c7c..c97913bc 100644
 --- a/chrome/content/torbutton.js
 +++ b/chrome/content/torbutton.js
 @@ -1861,9 +1861,10 @@ function showSecurityPreferencesPanel(chromeWindow)
 {

    if (settingsTab === null) {
        // Open up the settings panel in a new tab.
 -      tabBrowser.addTrustedTab(SECURITY_PREFERENCES_URI, {
 +      tabBrowser.addTab(SECURITY_PREFERENCES_URI, {
            "selected": true,
            "parentId": tabBrowser.selectedTab.id,
 +          triggeringPrincipal:
 Services.scriptSecurityManager.getSystemPrincipal(),
        });
    } else {
        // Activate an existing settings panel tab.
 }}}

 I pushed this to:
 https://github.com/sysrqb/torbutton.git
 branch `bug31010_00`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31010#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online