[tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Aug 30 17:40:55 UTC 2019


#31567: NS_tsnprintf() does not handle %s correctly on Windows
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  gk
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Critical                             |     Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,        |  Actual Points:
  TorBrowserTeam201908R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by cypherpunks):

 As for `__USE_MINGW_ANSI_STDIO`, now when ucrt is used, mingw-w64 should
 definitely be patched with
 {{{
 -# define __USE_MINGW_ANSI_STDIO 1
 +# define __USE_MINGW_ANSI_STDIO 0
 }}}
 in its ugly defaults:
 https://github.com/mingw-w64/mingw-w64/blob/f8e2c9ac594259fd2a46746943f84bd8766d7054/mingw-w64-headers/crt/_mingw.h.in#L428

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31567#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list