[tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows

[Tor Bug Tracker & Wiki]

#31567: NS_tsnprintf() does not handle %s correctly on Windows
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  gk
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Critical                             |     Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,        |  Actual Points:
  TorBrowserTeam201908R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mcs):

 Replying to [comment:7 gk]:
 > Here comes a 64bit testbuild and it's accompanied .mar file. mcs/brade:
 I know you don't have much time today but it would be helpful if you could
 give a short feedback whether that worked (assuming any of us has a hard
 time setting up the infrastructure for such a test today-ish):
 > ...

 Thanks for the builds, and Richard thank you *so* much for hacking on this
 last night. Unfortunately, the problem is not fixed and I think the same
 error is occurring (Unicode strings are being interpreted as C/ANSI
 strings). I do not know why, but maybe our cypherpunks are on the right
 track in that this may be a general problem with how updater.exe gets
 built.

 I will attach a Windows cmd file that can be used to run the updater
 "manually" to reproduce the problem. After you run the updater via the cmd
 file, look under `...\Browser\TorBrowser\UpdateInfo\updates\0` for newly
 created files. When the updater fails due to this bug, you will see status
 and log files there that are named sta<GUID> and log<GUID>. The GUID
 suffix is there because the rename (`MoveFileExW()` call) fails as I
 described in the bug description. The contents of the log file will be
 `failed setting status to 'applying'`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31567#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online