[tor-bugs] #31571 [Core Tor/Tor]: Add the tor version and a newline to raw_assert()

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Aug 30 15:10:13 UTC 2019


#31571: Add the tor version and a newline to raw_assert()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  diagnostics, 042-should, android,    |  Actual Points:  0.1
  macos, 035-backport, 040-backport,             |
  041-backport                                   |
Parent ID:  #31570                               |         Points:  0.1
 Reviewer:  nickm                                |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision
 * reviewer:   => nickm


Comment:

 Hi!  This looks like a solid set of changes to some tricky code.  I've
 left one suggestion and one question on the PR.

 CI appears to be passing.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31571#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list