[tor-bugs] #30967 [Core Tor/Tor]: Make shellcheck ignore user-created directories, and run it during pre-commit (was: Explicitly select the top-level directories that we want to shellcheck)

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Aug 30 13:08:04 UTC 2019


#30967: Make shellcheck ignore user-created directories, and run it during pre-
commit
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  unspecified
 Severity:  Major                                |     Resolution:
 Keywords:  fast-fix, teor-backlog-ci,           |  Actual Points:  0.2
  042-should, tor-ci-fail-sometimes              |
Parent ID:                                       |         Points:  0.1
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  assigned => needs_review
 * keywords:  fast-fix, teor-backlog-ci, 042-should => fast-fix, teor-
     backlog-ci, 042-should, tor-ci-fail-sometimes
 * actualpoints:   => 0.2


Comment:

 See my pull request:
 * master: https://github.com/torproject/tor/pull/1278

 I also added shellcheck to the pre-commit hook, because we've been failing
 CI with shellcheck errors.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30967#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list