[tor-bugs] #31552 [Core Tor]: --disable-module-dirauth broken (missing symbols)

[Tor Bug Tracker & Wiki]

#31552: --disable-module-dirauth broken (missing symbols)
-------------------------------------------------+-------------------------
 Reporter:  LarryBitcoin                         |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  accepted
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor                             |        Version:  Tor:
                                                 |  0.4.1.5
 Severity:  Normal                               |     Resolution:
 Keywords:  build, configure, features,          |  Actual Points:
  modules, regression                            |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * owner:  (none) => nickm
 * status:  new => accepted


Comment:

 Ah, this is for android!

 I suspect that the reason I can't reproduce this issue locally is that it
 has something to do with the behavior of LTO on the android toolchain
 specifically.  This is confirmed by #31301, which might be the same issue.

 Looking at the code: It seems that the functions that the compiler is
 complaining about are only called within blocks that, after compilation
 with --disable-module-dirauth, become "if (0) { ... }".  So I can believe
 that they are totally removed before linking sometimes, but not all the
 time.  The fix should be simple enough if this is the case.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31552#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online