[tor-bugs] #31544 [Core Tor/Tor]: sr: Check why some sr_disk_state fields need to be cleared

[Tor Bug Tracker & Wiki]

#31544: sr: Check why some sr_disk_state fields need to be cleared
------------------------------+-----------------------------------------
     Reporter:  teor          |      Owner:  nickm
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.4.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  network-team-roadmap-august
Actual Points:                |  Parent ID:  #29211
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+-----------------------------------------
 Split off #31240:

 teor: When we add fields, how will we make sure we remember to clear them
 all?

 nickm: We don't need to do so in general, the manager will take care of it
 for us. This is only necessary for derived fields, and fields for which
 the unit tests are expecting an unusual behavior, IIRC.

 nickm: (I can dig deeper here; I forget the exact reason why this function
 is clearing these, but I think it is because of legacy cruft.)

 teor: Yeah let's double-check what's going on here.



 https://github.com/nmathewson/tor/pull/3#discussion_r317548828

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31544>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online