[tor-bugs] #28238 [Applications/Tor Browser]: Use mingw-w64/clang toolchain to build Firefox

[Tor Bug Tracker & Wiki]

#28238: Use mingw-w64/clang toolchain to build Firefox
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-9.0-must-nightly,       |  Actual Points:
  TorBrowserTeam201908R, GeorgKoppen201908       |
Parent ID:  #30322                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by tom):

 > >  - fxc2 requires the winpthread dll to be in its bin directly IIRC;
 but I don't see where you're copying that. (I might have missed it. If
 you're not getting errors on fxc2 it must be working.)
 >
 > I think we don't need it when building with `mingw-w64-clang`. At least
 the build passes and I'd suspect compile time issues if that were a
 problem.
 >

 No, from my recollection it will compile fine but won't run if the dll is
 missing from the directory.  (However if firefox builds, then fxc2 didn't
 error and it worked...)


 > >  - I'm not sure what you do about PDBs; but it would be good to get a
 bug on file about generating/outputting them. (Perhaps in some
 configuration generating the static clang libraries with debug info also.)
 >
 > I agree. Right now don't generate them.

 I suspect you do generate them; but without setting MOZ_COPY_PDBs they are
 not winding up next to the outputed files so they're not winding up in the
 final tarball. You could stick that into the mozconfig and see if they
 show up though.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28238#comment:46>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online