[tor-bugs] #31241 [Core Tor/Tor]: Refactor config validation

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Aug 27 08:13:58 UTC 2019


#31241: Refactor config validation
-----------------------------------------+---------------------------------
 Reporter:  nickm                        |          Owner:  nickm
     Type:  task                         |         Status:  needs_revision
 Priority:  Medium                       |      Milestone:  Tor:
                                         |  0.4.2.x-final
Component:  Core Tor/Tor                 |        Version:
 Severity:  Normal                       |     Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #29211                       |         Points:  1.5
 Reviewer:                               |        Sponsor:  Sponsor31-can
-----------------------------------------+---------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Two unit tests failed on Windows:
 {{{
 options/validate__uname_for_server: [forking]
 6702  FAIL ../src/test/test_options.c:523: expected log to not contain
 entries  Captured logs:
 6703    1. warn: "Path for GeoIPFile (<default>) is relative and will
 resolve to C:\\projects\\tor\\x86_64-w64-mingw32\\<default>. Is this what
 you wanted?\n"
 6704    2. warn: "Path for GeoIPv6File (<default>) is relative and will
 resolve to C:\\projects\\tor\\x86_64-w64-mingw32\\<default>. Is this what
 you wanted?\n"
 6705
 6706  [validate__uname_for_server FAILED]
 …
 6720options/validate__paths_needed: [forking]
 6721  FAIL ../src/test/test_options.c:1460: expected log to not contain
 entries  Captured logs:
 6722    1. warn: "Path for GeoIPFile (<default>) is relative and will
 resolve to C:\\projects\\tor\\x86_64-w64-mingw32\\<default>. Is this what
 you wanted?\n"
 6723    2. warn: "Path for GeoIPv6File (<default>) is relative and will
 resolve to C:\\projects\\tor\\x86_64-w64-mingw32\\<default>. Is this what
 you wanted?\n"
 6724
 6725  [validate__paths_needed FAILED]
 6726options/validate__max_client_circuits: [forking] OK
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31241#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list