[tor-bugs] #30310 [Circumvention/Snowflake]: Snowflake localization

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Aug 26 19:02:06 UTC 2019


#30310: Snowflake localization
-------------------------------------------------+-------------------------
 Reporter:  cohosh                               |          Owner:  arlolra
     Type:  task                                 |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:
Component:  Circumvention/Snowflake              |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  l10n, snowflake-webextension, anti-  |  Actual Points:
  censorship-roadmap-august                      |
Parent ID:                                       |         Points:
 Reviewer:  cohosh                               |        Sponsor:
                                                 |  Sponsor28-can
-------------------------------------------------+-------------------------
Changes (by cohosh):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:23 arlolra]:
 > > Does call to writeFileSync with data from availableLangs ​R43 do the
 same as copying the translated files in a previous commit: ​R78? Do we
 need to remove the copy logic for the proxy if so?
 >
 > No, the `writeFileSync` in `R43` is concatenating code to the embed.js
 file so that the known `availableLangs` are present there.
 >
 > The copying in `R78` is moving the completed translations to a web
 accessible place, to be fetched based on the `availableLangs`.
 >
 > > Do we need to manually update the submodule when there are new
 translations before they become available?
 >
 > The translation.git repo will be updated automatically when new
 translations are completed.  However, when we're ready to make a new
 release, we do need to manually update the submodule beforehand.  So, `git
 submodule update --remote`, then git add, commit, push.  Followed by
 whatever regular release steps we do.

 Okay nice. Looks ready to merge.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30310#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list