[tor-bugs] #21003 [Core Tor/Tor]: extend_info_describe should list IPv6 address (if present)

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Aug 26 14:17:15 UTC 2019


#21003: extend_info_describe should list IPv6 address (if present)
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  easy, intro, ipv6, logging, fast-    |  Actual Points:  0.3
  fix, no-backport, asn-merge nickm-merge        |
Parent ID:  #31088                               |         Points:  0.5
 Reviewer:  dgoulet                              |        Sponsor:
                                                 |  Sponsor27-can
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * keywords:  easy, intro, ipv6, logging, fast-fix, no-backport =>
     easy, intro, ipv6, logging, fast-fix, no-backport, asn-merge nickm-
     merge
 * status:  needs_review => merge_ready
 * sponsor:   => Sponsor27-can


Comment:

 Looks good!

 One of my worry was that we were removing one side of the `LongName`
 format from the control spec with this:

 {{{
 -   buf[1+HEX_DIGEST_LEN] = is_named ? '=' : '~';
 +   buf[1+HEX_DIGEST_LEN] = '~';
 }}}

 where `LongName` from the control spec is:

 {{{
 LongName   = Fingerprint [ ( "=" / "~" ) Nickname ]
 }}}

 I went over the control subsystem and we appear to be OK there.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21003#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list