[tor-bugs] #31483 [Core Tor/Tor]: token_bucket_ctr_adjust() does not convert rate to step

[Tor Bug Tracker & Wiki]

#31483: token_bucket_ctr_adjust() does not convert rate to step
--------------------------------+--------------------------------
     Reporter:  teor            |      Owner:  dgoulet
         Type:  defect          |     Status:  assigned
     Priority:  Medium          |  Milestone:  Tor: 0.4.2.x-final
    Component:  Core Tor/Tor    |    Version:  Tor: unspecified
     Severity:  Normal          |   Keywords:  042-must
Actual Points:                  |  Parent ID:
       Points:  0.5             |   Reviewer:
      Sponsor:  Sponsor31-must  |
--------------------------------+--------------------------------
 In #30687, we created a single-counter token bucket token_bucket_ctr.

 token_bucket_rw_adjust() calls rate_per_sec_to_rate_per_step(rate), but
 token_bucket_ctr_adjust() does not.

 I suggest we fix this bug by moving rate_per_sec_to_rate_per_step(rate)
 into token_bucket_cfg_init(). And we should add some documentation that
 explains the difference between rate and burst.

 Gaba, this is sponsor 31-must, because it is a bug fix on sponsor 31 code
 that has already been merged.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31483>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online