[tor-bugs] #31226 [Internal Services/Tor Sysadmin Team]: add validation checks in puppet

[Tor Bug Tracker & Wiki]

#31226: add validation checks in puppet
-------------------------------------------------+---------------------
 Reporter:  anarcat                              |          Owner:  tpa
     Type:  enhancement                          |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Internal Services/Tor Sysadmin Team  |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:                                       |  Actual Points:
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+---------------------

Comment (by anarcat):

 The following packages are used by the check:

 * librarian-puppet
 * puppet-strings
 * ruby-rspec
 * r10k

 ... and probably more, those were just the ones missing on my machine.

 one big downside with such a check is that it will fail if the modified
 file has *any* linting error, even if it wasn't introduced by the commit.
 this means deploying this will lead to significant churn in the codebase
 as we'll need to lint each file we touch in the future...

 kind of annoying, but i can't think of a way around that without disabling
 linting. but maybe it's a good way to start: even without linting, we
 would catch other syntax errors, run tests, etc...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31226#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online