[tor-bugs] #31452 [Core Tor/Tor]: Fix coverity failures in unit tests as of 19 August 2019

[Tor Bug Tracker & Wiki]

#31452: Fix coverity failures in unit tests as of 19 August 2019
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:  nickm
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.4.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 Other than #31451 and a deadcode issue in trunnel, our current "new" and
 "triaged" issues are all in the unit tests.

 Let's fix them all, to keep our code quality up.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31452>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online