[tor-bugs] #30429 [Applications/Tor Browser]: Rebase Tor Browser patches for Firefox ESR 68

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Aug 19 09:01:25 UTC 2019


#30429: Rebase Tor Browser patches for Firefox ESR 68
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-9.0-must-nightly,                |  Actual Points:
  TorBrowserTeam201908R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:26 acat]:
 > Thanks again for the reviews. A new branch addressing your comments and
 some small issues I found: https://github.com/acatarineu/tor-
 browser/commits/30429+6

 Looks mostly good now (I still need to look at the onboarding stuff,
 though):

 [snip]

 > >9442dda80f9beb90b90934da2bb1a614d39117a4 - not okay. The test is
 probably not working anymore as we don't have static pins for #29811; we
 should either drop it or fix #29811 and test that the test is still
 working then (or working then again)
 > I dropped it, i can add a comment to #29811 to add it again when it is
 fixed.

 Sounds good, please do.

 [snip]

 Could you adapt the commit message for
 3fe947023d1146e61dfe08f941cc269e2441cd62? You could just drop the ESR45
 paragraph or change it in a way that reflects what we actually block with
 the patch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30429#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list