[tor-bugs] #31356 [Core Tor/Tor]: 0.4.0 relays should not list Padding=1

[Tor Bug Tracker & Wiki]

#31356: 0.4.0 relays should not list Padding=1
--------------------------+------------------------------
 Reporter:  mikeperry     |          Owner:  (none)
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:  Tor: 0.4.0.5
 Severity:  Normal        |     Resolution:
 Keywords:  wtf-pad       |  Actual Points:
Parent ID:                |         Points:  1
 Reviewer:                |        Sponsor:  Sponsor2
--------------------------+------------------------------

Comment (by mikeperry):

 Replying to [comment:1 teor]:
 > Travis says:
 > {{{
 > clang -DHAVE_CONFIG_H -I.  -I./src -I./src/ext -I./src/ext/trunnel
 -I./src/trunnel -I./src/ext -Isrc/ext
 -DSHARE_DATADIR="\"/usr/local/share\""
 -DLOCALSTATEDIR="\"/usr/local/var\"" -DBINDIR="\"/usr/local/bin\""
 -DTOR_UNIT_TESTS  -DHAVE_MODULE_DIRAUTH=1  -ftrapv -fsanitize=address
 -fno-sanitize=float-divide-by-zero     -g -O2 -U_FORTIFY_SOURCE
 -D_FORTIFY_SOURCE=2 -Qunused-arguments -fstack-protector-all -Wstack-
 protector --param ssp-buffer-size=1 -fPIE -fno-omit-frame-pointer
 -fasynchronous-unwind-tables -Wall -fno-strict-aliasing -Werror
 @warning_flags -MT src/core/or/src_core_libtor_app_testing_a-
 circuitpadding.o -MD -MP -MF src/core/or/.deps
 /src_core_libtor_app_testing_a-circuitpadding.Tpo -c -o src/core/or
 /src_core_libtor_app_testing_a-circuitpadding.o `test -f
 'src/core/or/circuitpadding.c' || echo './'`src/core/or/circuitpadding.c
 >
 > src/core/or/circuitpadding.c:218:1: error: version control conflict
 marker in
 >
 >       file
 >
 > <<<<<<< HEAD
 >
 > ^
 >
 > src/core/or/circuitpadding.c:236:1: error: version control conflict
 marker in
 >
 >       file
 >
 > <<<<<<< HEAD
 >
 > ^
 >
 > src/core/or/circuitpadding.c:244:16: error: format specifies type 'char
 *' but
 >
 >       the argument has type 'int' [-Werror,-Wformat]
 >
 >                i, circuit_purpose_to_string(circ->purpose));
 >
 >                ^
 >
 > ./src/lib/log/log.h:266:53: note: expanded from macro 'log_notice'
 >
 >   log_fn_(LOG_NOTICE, domain, __FUNCTION__, args, ##__VA_ARGS__)
 >
 >                                                     ^~~~~~~~~~~
 >
 > src/core/or/circuitpadding.c:244:19: error: data argument not used by
 format
 >
 >       string [-Werror,-Wformat-extra-args]
 >
 >                i, circuit_purpose_to_string(circ->purpose));
 >
 >                ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 >
 > ./src/lib/log/log.h:266:53: note: expanded from macro 'log_notice'
 >
 >   log_fn_(LOG_NOTICE, domain, __FUNCTION__, args, ##__VA_ARGS__)
 >
 >                                             ~~~~    ^
 >
 > 4 errors generated.
 > }}}

 Did I mentiin my PR on any ticket before you posted this message? Was this
 a good use of your time?

 What were you trying to accomplish here? I am honestly curious.

 Is there a good reason to watch *all* PRs run for the purpose of
 exercising CI?

 Seriously... This is kind of crazy.. let's discuss.

 Anyway, since we're here, we might as well treat this PR as final cause
 that's how we do, apparently.

 Thanks.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31356#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online