[tor-bugs] #31010 [Applications/Tor Browser]: Rebase Tor Browser mobile/ patches for Firefox ESR 68

[Tor Bug Tracker & Wiki]

#31010: Rebase Tor Browser mobile/ patches for Firefox ESR 68
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-9.0-must-nightly,    |  Actual Points:
  TorBrowserTeam201908R                          |
Parent ID:  #30429                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by sysrqb):

 * cc: mcs, brade (added)


Comment:

 Bisecting leads to [https://github.com/acatarineu/tor-
 browser/commit/d03d360bd773c8d8a97ef1f69e565afcc19796e5 this commit]
 (commit `d03d360bd773c8d8a97ef1f69e565afcc19796e5` on acat's `30429+5`
 branch). This'll require some digging. mcs/brade, if you have any
 suggestions about where I should look, they'll be very much appreciated.

 Specifically, I'm hitting [https://searchfox.org/mozilla-
 esr68/source/toolkit/xre/nsAndroidStartup.cpp#49 this result]:
 {{{
 08-06 21:08:45.266 4117-4141/org.torproject.torbrowser I/fennec: XRE_main
 returned 1
 }}}

 I'm having trouble setting breakpoints in the code, so I'm working through
 the code manually right now. I think this failure is triggered after
 [https://searchfox.org/mozilla-
 esr68/source/toolkit/xre/nsAppRunner.cpp#4781 mScopedXPCOM->Initialize()]
 because I'm getting the log message:
 {{{
 08-06 21:08:44.163 4117-4141/org.torproject.torbrowser D/GeckoThread:
 State changed to JNI_READY
 }}}

 and I believe that is set [https://searchfox.org/mozilla-
 esr68/source/widget/android/nsAppShell.cpp#424 at the end] of the
 `Initialize()` call (after a few layers of indirection, assuming I traced
 this correctly).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31010#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online