[tor-bugs] #30126 [Applications/Tor Browser]: Make Tor Browser on macOS compatible with Apple's notarization

[Tor Bug Tracker & Wiki]

#30126: Make Tor Browser on macOS compatible with Apple's notarization
------------------------------------------------+--------------------------
 Reporter:  gk                                  |          Owner:  tbb-team
     Type:  task                                |         Status:  new
 Priority:  Very High                           |      Milestone:
Component:  Applications/Tor Browser            |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  tbb-security, TorBrowserTeam201908  |  Actual Points:
Parent ID:                                      |         Points:
 Reviewer:                                      |        Sponsor:
------------------------------------------------+--------------------------

Comment (by teor):

 Replying to [comment:33 gk]:
 > Replying to [comment:32 mcs]:
 > > Replying to [comment:31 gk]:
 > > > Alright: mcs/brade how does:
 > > >
 > > > https://people.torproject.org/~gk/testbuilds/TorBrowser-tbb-nightly-
 30126_4-osx64_en-US.dmg
 > > > https://people.torproject.org/~gk/testbuilds/TorBrowser-tbb-nightly-
 30126_4-osx64_en-US.dmg.asc
 > >
 > > That build fixes the problem with `tor.real`. With tor working, we
 could test further on macOS 10.9. Unfortunately, meek is not working.
 Trying to exec `meek-client-torbrowser` shows:
 > > {{{
 > >  dyld: Symbol not found: _unlinkat
 > >   Referenced from: .../Tor
 Browser.app/Contents/MacOS/./Tor/PluggableTransports/meek-client-
 torbrowser
 > >   Expected in: flat namespace
 > > }}}
 > >
 > > According to the unlink/unlinkat man page on macOS 10.14, "The
 unlinkat() system call appeared in OS X 10.10."
 >
 > So, we have min OS version 10.9 and SDK version 10.9 but a syscall got
 used that appeared in 10.10? Weird.

 In 10.10.0, Apple correctly declared unlinkat() as only available in 10.10
 and later:
 {{{
 int     unlinkat(int, const char *, int)
 __OSX_AVAILABLE_STARTING(__MAC_10_10, __IPHONE_8_0);
 }}}
 https://opensource.apple.com/source/xnu/xnu-2782.1.97/bsd/sys/unistd.h.auto.html
 }}}
 In 10.9.5 and earlier, unlinkat() does not exist, and is not declared by
 Apple.

 Maybe Go's bindings are wrong?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30126#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online