[tor-bugs] #31343 [Core Tor/Tor]: appveyor: labs(time_t) is not allowed

[Tor Bug Tracker & Wiki]

#31343: appveyor: labs(time_t) is not allowed
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Critical                             |     Resolution:
 Keywords:  backports? 041-must tor-ci           |  Actual Points:  .1
  029-backport 035-backport 040-backport         |
  041-backport                                   |
Parent ID:                                       |         Points:
 Reviewer:  mikeperry                            |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * priority:  Medium => Very High
 * status:  needs_review => needs_revision
 * severity:  Normal => Critical


Comment:

 I did a quick review here, because the appveyor failures are blocking
 backport merges.

 I think the new code warns on any skew, but the old code only warned on
 skews over 1 hour. That change is not documented in the changes file, and
 seems to be a mistake?

 Also, because the old code only warned on skews over 1 hour, the changes
 file has a confusing description of the old behaviour.

 See my commends on the PR for details.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31343#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online