[tor-bugs] #31344 [Applications/Tor Browser]: SecurityLevelPreferences.uninit() never called on exit of about:preferences

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Aug 5 22:40:27 UTC 2019


#31344: SecurityLevelPreferences.uninit() never called on exit of about:preferences
------------------------------------------+--------------------------------
     Reporter:  pospeselr                 |      Owner:  pospeselr
         Type:  defect                    |     Status:  assigned
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:
                                          |  TorBrowserTeam201908
Actual Points:                            |  Parent ID:
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+--------------------------------
 Found this while building out a skeleton for #31286. Looks like I didn't
 actually register the unload event callback, so the object's observer
 callback is never removed. Worst case scenario the 'observe' callback will
 be called for every time the user has entered about:preferences and
 repeatedly edit the XUL to reflect the changed security_slider value. Not
 *really* a problem but I'll have a fixup patch shortly.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31344>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list