[tor-bugs] #31176 [Core Tor/Tor]: Teach practracker about .may_include files

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Aug 5 21:58:39 UTC 2019


#31176: Teach practracker about .may_include files
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  practracker, tech-debt,              |  Actual Points:  1
  refactoring, easy, 041-deferred-20190530,      |
  network-team-roadmap-august                    |
Parent ID:  #29746                               |         Points:  1.5
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by nickm):

 * actualpoints:   => 1


Comment:

 See branch `ticket31176` with PR in
 https://github.com/torproject/tor/pull/1206 .

 This branch comes in two main parts.  In the first part, I refactor
 checkIncludes.py until it can be integrated into practracker.  In the
 second, I move checkIncludes.py to practracker/includes.py, and teach it
 that some violations are "advisory only" -- to be counted as best-
 practices violations, but not to cause build failures.

 I've added .may_include files to src/core/* for this, since that is where
 we currently most want to push the modularity boundary.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31176#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list