[tor-bugs] #30901 [Core Tor/Tor]: Add control port trace logging to tor

[Tor Bug Tracker & Wiki]

#30901: Add control port trace logging to tor
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-ci-fail-sometimes network-team-  |  Actual Points:  1.8
  roadmap-august                                 |
Parent ID:  #29437                               |         Points:  1
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by teor):

 * actualpoints:  0.8 => 1.8


Comment:

 The code works, and produces log output like:
 {{{
 Aug 06 01:35:53.760 [debug] conn_read_callback: socket 8 wants to read.
 Aug 06 01:35:53.760 [debug] read_to_chunk: Read 48 bytes. 48 on inbuf.
 T= 1565019353 Control Trace Conn: 0x611000002200, Command Read: Content:
 "AUTHENTICATE \r\n".
 Aug 06 01:35:53.761 [info] handle_control_authenticate: Authenticated
 control connection (8)
 T= 1565019353 Control Trace Conn: 0x611000002200, Reply Printf: Content:
 "250 OK\r\n".
 }}}
 The output is raw, because we can't use the log module from the
 control_trace module.

 I still need to split out some of the commits into separate branches, and
 squash the remaining commits.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30901#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online